Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] use --variant instead of --mode #4210

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gasolin
Copy link

@gasolin gasolin commented Sep 9, 2024

new expo cli command use --variant instead of --mode to specify the android debug/release mode

https://docs.expo.dev/more/expo-cli/#compiling-android

@facebook-github-bot
Copy link

Hi @gasolin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 5603971
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/66f0c41284edb00008d0d55a
😎 Deploy Preview https://deploy-preview-4210--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/running-on-device.md Outdated Show resolved Hide resolved
@@ -163,7 +163,7 @@ yarn android
</TabItem>
</Tabs>

> Hint: You can also use the `React Native CLI` to generate and run a `release` build (e.g. from the root of your project: `yarn android --mode release`).
> Hint: You can also use the `React Native CLI` to generate and run a `release` build (e.g. from the root of your project: `yarn android --variant release`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@@ -301,7 +301,7 @@ yarn android

> If you get a "bridge configuration isn't available" error, see [Using adb reverse](running-on-device.md#method-1-using-adb-reverse-recommended).

> Hint: You can also use the `React Native CLI` to generate and run a `release` build (e.g. from the root of your project: `yarn android --mode release`).
> Hint: You can also use the `React Native CLI` to generate and run a `release` build (e.g. from the root of your project: `yarn android --variant release`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@gasolin gasolin requested a review from cortinico September 23, 2024 01:28
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the CLI documentation and the reccomended flag is actually --mode:

https://github.com/react-native-community/cli/blob/main/packages/cli-platform-android/README.md#build-android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants