feat: add error documentation links to LSP diagnostics #1273
Conversation
- Add ErrorKind::docs_url() method that generates stable HTTPS URLs to error documentation - Include codeDescription field in LSP diagnostics with href pointing to error docs - Add comprehensive test for error documentation links in LSP diagnostic responses - Test covers multiple error types: bad-assignment, bad-context-manager, missing-attribute This enables LSP clients (VS Code, Vim, etc.) to provide clickable links to error documentation in their Problems panel, improving developer experience and error understanding.
|
Hi @abdallhfattah! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
looks perfect! one final test: can you screen record what it looks like in the IDE? |
2 participants
This enables LSP clients (VS Code, Vim, etc.) to provide clickable links to error documentation in their Problems panel, improving developer experience and error understanding.
Fixes #1206