hpa_central refactor - extract hpa_central and some utilities from hpa #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spredolac
added
cleanup
spredolac
force-pushed
the
central_refactor
branch
from
0140f31 to
11aeec5
Compare
guangli-dai
requested changes
Nov 19, 2025
guangli-dai
left a comment
guangli-dai
left a comment
There was a problem hiding this comment.
With new c files added, they need to be added into the corresponding MSVC doc like this.
guangli-dai
reviewed
Nov 20, 2025
| } | ||
| TEST_END | ||
|
|
||
| TEST_BEGIN(test_more_pages_than_batch_page_size) { |
There was a problem hiding this comment.
Maybe change the name here as well? While the test moves away from a file where madvise was specified, this filename doesn't have such implications so the test name should be more explicit? What about test_purge_more_than_one_batch_pages?
…h, move shard independent actions to hpa_utils
spredolac
force-pushed
the
central_refactor
branch
2 times, most recently
from
e7895e9 to
86611df
Compare
spredolac
commented
Nov 21, 2025
| <ImportGroup Label="ExtensionTargets"> | ||
| </ImportGroup> | ||
| </Project> | ||
| </Project> |
Author
There was a problem hiding this comment.
This was automatically added by emacs as it was unclosed tag.
spredolac
force-pushed
the
central_refactor
branch
from
86611df to
d422a54
Compare
guangli-dai
reviewed
Nov 27, 2025
| <ClCompile Include="..\..\..\..\src\hpa.c"> | ||
| <Filter>Source Files</Filter> | ||
| </ClCompile> | ||
| <ClCompile Include="..\..\..\..\src\hpa_central.c"> |
There was a problem hiding this comment.
I think we also need to addhpa_utils.c in? Besides, I notice thread_event_registry.c is also missing from the filters files, can you help add it in as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
code readability, modularity and better encapsulation
Changes
hpa_centralis moved out ofhpa.cfilehpa.cwhich will allow their reuse when batch purging is needed. They are also made not dependent on hpa_shard, but only on hpa_hooks as that is all they needTesting
No logic change, tests are modified to reflect new code.