icecube:config: update fsc config according to thermal fsc update #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Fan Service configuration to align with the FSC strategy V1.0 requirement. Modification includes fan control values based on new FSC requirements and removal of configuration for the following unused temperature sensors: PIC_B_U12_INLET_LM75_2_TEMP and MCB_POWER_BRICK3_TEMP.
Motivation
This update is required to comply with the Thermal Team's new FSC strategy V1.0:
https://docs.google.com/presentation/d/1Jf6roBPiwX8O6JTdb-erTOqP2FrGYfm9KNJWbsd6hic/edit?slide=id.g340615defe5_0_1537#slide=id.g340615defe5_0_1537
The FSC strategy V1.0 states that both the system inlet sensor PIC_T_U12_INLET and the CPU_internal sensor values can be used to determine fan PWM values. The CPU_internal sensor uses a PID algorithm to determine the PWM value, while the PIC_T_U12_INLET sensor uses a LINEAR_TABLE algorithm to determine the PWM value. The largest PWM value of the two is used as the final fan PWM value.
Also modify pwmMax value from 40 to 64 according to CPLD pwmMax value changed to 64 for enhancement fan control accuracy.
Test Log
Attach the fan_service test log:
icecube_fsc_test_log.txt