Skip to content

Ladakh800bcls: Platform: Add Ladakh800bcls fan_service, fw_util, led_manager, sensor_service configuration after bring up #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Ladakh800bcls: Platform: Add Ladakh800bcls fan_service, fw_util, led_manager, sensor_service configuration after bring up #584

wants to merge 4 commits into from

Conversation

@chee-zhang
Copy link
Contributor

@chee-zhang chee-zhang commented Oct 10, 2025 •
edited
Loading

Description

This PR is about Ladakh800bcls platform configurations for EVT1 phase.

Motivation

led_manager

Based on Ladakh800bcls HW Design Specification EVT1, the LEDs below should be added.

  1. 4x Tri-color LEDs for status indication, one PWR LED, one Sys LED, SMB LED and one FAN LED.
  2. 6x Bi-color LEDs for FAN tray.

fw_util

Based on Ladakh800bcls HW Design Specification EVT1 and the FPGA Register Map, the following upgrade devices should be added.

image

sensor_service

Based on Ladakh800bcls HW Design Specification EVT1.

  1. Add the thermal sensors.
  2. Add the voltage and current detection sensors.

fan_service

Based on Ladakh800bcls HW Design Specification EVT1.

486578675-240493a7-4d35-4c2e-8dbf-f2717151488a
  1. The CPU_UNCORE_TEMP, INLET_TEMP on RTM_L, INLET_TEMP on RTM_R, MCB_POWER_BRICK3_TEMP are considered in the draft version.
  2. 6 fans are considered.

Test Plan

  1. Used jq command to pretty the format.
  2. Compilation and config validation have passed based on Ladakh800bcls: Platform: Add Ladakh800bcls platform config after bring up #537
I1028 23:21:17.308879 2308103 ConfigGenerator.cpp:113] Processing platform ladakh800bcls in /work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls
I1028 23:21:17.309004 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/bsp_tests.json"
I1028 23:21:17.312866 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/fan_service.json"
I1028 23:21:17.316480 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/fw_util.json"
I1028 23:21:17.319443 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/led_manager.json"
I1028 23:21:17.321964 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/sensor_service.json"
I1028 23:21:17.327983 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/showtech.json"
I1028 23:21:17.330609 2308103 ConfigGenerator.cpp:121] Processing config "/work/users/cheezhang/fboss/fboss/platform/configs/ladakh800bcls/platform_manager.json"
I1028 23:21:17.331477 2308103 ConfigValidator.cpp:557] Validating platform_manager config
I1028 23:21:17.331497 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot COMESE_SLOT...
I1028 23:21:17.331509 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot MCB_SLOT...
I1028 23:21:17.331516 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot RTM_L_SLOT...
I1028 23:21:17.331523 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot RTM_R_SLOT...
I1028 23:21:17.331530 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot RUNBMC_SLOT...
I1028 23:21:17.331538 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot SMB_L_SLOT...
I1028 23:21:17.331546 2308103 ConfigValidator.cpp:583] Validating SlotTypeConfig for Slot SMB_R_SLOT...
I1028 23:21:17.331553 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit BMC in Slot RUNBMC_SLOT...
I1028 23:21:17.331563 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit LADAKH800BCLS_MCB in Slot MCB_SLOT...
I1028 23:21:17.331655 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit NETLAKE in Slot COMESE_SLOT...
I1028 23:21:17.331671 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit RTM_L in Slot RTM_L_SLOT...
I1028 23:21:17.331683 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit RTM_R in Slot RTM_R_SLOT...
I1028 23:21:17.331695 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit SMB_L in Slot SMB_L_SLOT...
I1028 23:21:17.331708 2308103 ConfigValidator.cpp:600] Validating PmUnitConfig for PmUnit SMB_R in Slot SMB_R_SLOT...
I1028 23:21:17.331721 2308103 ConfigValidator.cpp:654] Validating Symbolic links...
I1028 23:21:17.335198 2308103 ConfigValidator.cpp:661] Validating Transceiver symbolic links...
I1028 23:21:17.335443 2308103 ConfigValidator.cpp:16] Validating sensor_service config
I1028 23:21:17.336406 2308103 CrossConfigValidator.cpp:25] Cross validating sensor_service config
I1028 23:21:17.337705 2308103 ConfigValidator.cpp:47] Validating fan_service config
I1028 23:21:17.337830 2308103 CrossConfigValidator.cpp:54] Cross validating fan_service config
I1028 23:21:17.337946 2308103 ConfigValidator.cpp:10] Validating data_corral_service config
I1028 23:21:17.337960 2308103 ConfigValidator.cpp:12] Validating the system LED config
I1028 23:21:17.337967 2308103 ConfigValidator.cpp:77] Validating the LED config for fruType: FAN
I1028 23:21:17.337973 2308103 ConfigValidator.cpp:77] Validating the LED config for fruType: PWR
I1028 23:21:17.337980 2308103 ConfigValidator.cpp:77] Validating the LED config for fruType: SMB
I1028 23:21:17.337990 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: FAN1
I1028 23:21:17.337997 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: FAN2
I1028 23:21:17.338003 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: FAN3
I1028 23:21:17.338011 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: FAN4
I1028 23:21:17.338018 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: FAN5
I1028 23:21:17.338026 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: FAN6
I1028 23:21:17.338032 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: PWR
I1028 23:21:17.338043 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: SMB_L
I1028 23:21:17.338050 2308103 ConfigValidator.cpp:89] Validating the FRU config for fru: SMB_R

build.log

  1. The HW tests below passed.

To be verified with new name

@meta-cla meta-cla bot added the CLA Signed label Oct 10, 2025
@chee-zhang chee-zhang marked this pull request as ready for review October 13, 2025 06:37
@chee-zhang chee-zhang mentioned this pull request Oct 14, 2025
Closed
@chee-zhang chee-zhang changed the title Anacapa: Platform: Add Anacapa fan_service, fw_util, led_manager, sensor_service configuration after bring up Ladakh800bcls: Platform: Add Ladakh800bcls fan_service, fw_util, led_manager, sensor_service configuration after bring up Oct 29, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 29, 2025

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D85795573.

@chee-zhang chee-zhang force-pushed the anacapa_platform_config branch from 605a822 to 2ee1914 Compare October 30, 2025 10:16
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 30, 2025

@chee-zhang has updated the pull request. You must reimport the pull request before landing.

@meta-codesync meta-codesync bot closed this in 56f935a Oct 31, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 31, 2025

@mikechoifb merged this pull request in 56f935a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chee-zhang @facebook-github-bot