[Showtech] Add System Logs to Showtech, fix Showtech execCommand bug #581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Add printing fboss service logs and other debug logs to showtech
Fix bug where
platformUitls.execCommand()
throws an exception if the child process was killed (interupt, core dump, etc) causing showtech to crashChange
Utils::printServiceLogs()
to print various debug logs truncated to 5000 lines eachplatformUtils_.execCommand(cmd)
intosafeExecCommand(cmd)
to handle any exceptions thrownTesting
Internally we saw fw_util failure causing showtech to crash, after the changes verified
showtech --details fwutil
no longer crashSample showtech output for
showtech --details logs
with maxLine set to 10 lines (actual implementation is 5000)