Skip to content

Conversation

@pawagh1
Copy link
Contributor

@pawagh1 pawagh1 commented Oct 9, 2025

This update refines the sensor_service.json configuration for the MCB to align with the latest threshold definitions and to remove deprecated or hidden sensor entries no longer in use.

Key highlights of this update:

  1. Removal of Deprecated Sensors:
    The following sensors were identified as obsolete and have been removed to maintain a clean and relevant sensor configuration:

    • MCB_P12V_BP_ADC0_A
    • MCB_P12V_BP_ADC0_B
  2. Threshold Definition Updates:
    Threshold parameters for existing sensors have been refreshed to the latest defined values. This includes updates to:

    • upperCriticalVal and lowerCriticalVal
    • Newly added maxAlarmVal and minAlarmVal where applicable
      These changes ensure accurate alarm triggering and improved monitoring reliability within expected operational ranges.

No new sensors were added as part of this update. Existing sensor attributes such as slotPath, sysfsPath, pmUnitName, and type remain consistent with previous configurations.

Test Plan:

  1. Confirm all sensors are enabled and reporting valid readings.
  2. Verify all sensor values are within the defined threshold limits.
  3. Ensure removed sensors (MCB_P12V_BP_ADC0_A, MCB_P12V_BP_ADC0_B) are not listed.

@meta-cla
Copy link

meta-cla bot commented Oct 9, 2025

Hi @pawagh1!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@somasun
Copy link
Contributor

somasun commented Oct 9, 2025

@pawagh1 - please take care of the CLA. Also, please take a look at other PRs in the repository for examples on detailed Summary and Test Plan.

@meta-cla meta-cla bot added the CLA Signed label Oct 13, 2025
@meta-cla
Copy link

meta-cla bot commented Oct 13, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@somasun
Copy link
Contributor

somasun commented Oct 30, 2025

Can you please also add a Summary and TestPlan for this change? You can look at other PRs for examples

@meta-codesync
Copy link

meta-codesync bot commented Oct 30, 2025

@somasun has imported this pull request. If you are a Meta employee, you can view this in D85884593.

@somasun
Copy link
Contributor

somasun commented Nov 4, 2025

thanks for the test plan @pawagh1

@meta-codesync
Copy link

meta-codesync bot commented Nov 4, 2025

@somasun merged this pull request in 0a1933f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants