Align fw_util spi_layout for BIOS verify and read commands with upgrade command #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joancaneus has imported this pull request. If you are a Meta employee, you can view this in D84928717. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a bug where the
spi_layoutwas missing from the BIOSverifyandreadcommand configurations in the fw_util config files. This caused the layout for these commands to not match the one used by the upgrade command. This issue was introduced during a refactoring a few months ago, when thepreUpgradeCmdwas removed.Testing
Verified BIOS read and verify commands on darwin, darwin48v, meru800bfa and meru800bia systems.