Skip to content

Conversation

@egenny
Copy link

@egenny egenny commented Oct 23, 2023

Allow the constructor to accept a block and store it in an instance variable for use by the request method.

The block allows the inclusion of Faraday Middleware.

@facebook-github-bot
Copy link

Hi @egenny!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@egenny egenny force-pushed the add-connection-setup branch 2 times, most recently from 2a63828 to 7a4d255 Compare October 24, 2023 16:02
@egenny egenny marked this pull request as ready for review November 1, 2023 19:49
@egenny egenny force-pushed the add-connection-setup branch from 7a4d255 to 8ad95d1 Compare June 21, 2024 15:29
egenny added 2 commits April 24, 2025 23:15
Allow the constructor to accept a block and store it in
an instance variable as a proc for configuring Faraday.

The block allows the inclusion of Faraday Middleware, for example:

FacebookAds::Session.new(
     access_token: "a_token",
     app_secret: "a_secret
) { |faraday| faraday.response :my_faraday_middleware }
execute will use the passed in session if available
or create a session from the access_token if no
session is available.

This allows Faraday middleware to be used by EventRequest.

session = FacebookAds::Session.new(access_token: token) { |faraday| faraday.response :some_faraday_middleware }

FacebookAds::ServerSide::EventRequestAsync.new(
      pixel_id: pixel_id,
      events: [event],
      session: session,
    )
@afn afn force-pushed the add-connection-setup branch from 33965ce to 2cd1b2c Compare April 25, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants