Tiny refactoring

[slawa85]

This PR bring some small refactoring. The part with removed &block from method signature reduce a bit the code readability but increase the performance accordingly to this article https://mudge.name/2011/01/26/passing-blocks-in-ruby-without-block.html

[fabrik42]

Hi! Thank you for submitting this PR.

You added this commit:
648ca55

Why do you think the check is redundant?

Best,
Christian

[slawa85]

Hi,
As I saw, the meta_tags are not used at all in that sequence if code which is running once the condition is true, instead you are merging meta_tags here, that's why I considered it redundant there.

[fabrik42]

Hi,
first of all, sorry for answering so slowly.

It is correct that the meta hash is not used at all in this line.

It basically prepares the api response object to include the meta hash. The rule is, we don't want to mix the meta hash and the object that gets rendered. So we force a root node, if there is a meta hash. So this needs to stay, but there really should have been a test indicating that this is a required behaviour, so shame on me :)

Regarding the performance improvent:
This is something I didn't knew and I like it, thanks!

Best,
Christian

[slawa85]

Hi,

Thank you for explanation, now I got your idea and the approach that you use. I will edit my PR to include only the performance approach if you agree.

[fabrik42]

Sounds good! 👍