-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trust Agreement v3.6: Improve clarity of legal language #21
Open
devin-ai-integration
wants to merge
11
commits into
main
Choose a base branch
from
devin/1734414326-trust-agreement-refinements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Trust Agreement v3.6: Improve clarity of legal language #21
devin-ai-integration
wants to merge
11
commits into
main
from
devin/1734414326-trust-agreement-refinements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace 'burn' with 'redeem' throughout the document - Generalize blockchain network definition to support L2s - Improve clarity of redeem function description - Maintain consistent terminology in dissolution event section Co-Authored-By: Federico Pomi <[email protected]>
…beneficial ownership - Clarify distinction between token custody and beneficial ownership in Section 1 - Update terminology to consistently use 'Redeem' instead of 'locked or destroyed' - Enhance Section 6.2 to explicitly reference Contract Account custody - Align legal language with Section 7.3's ownership principles Co-Authored-By: Federico Pomi <[email protected]>
- Add changelog entry for trust agreement improvements - Document enhanced clarity around token custody vs. ownership - Note strengthened legal language for Contract Account interactions Note: IPFS CID pending Co-Authored-By: Federico Pomi <[email protected]>
Co-Authored-By: Federico Pomi <[email protected]>
…ract custody scenarios Co-Authored-By: Federico Pomi <[email protected]>
devin-ai-integration
bot
force-pushed
the
devin/1734414326-trust-agreement-refinements
branch
from
December 17, 2024 08:09
3f49318
to
5059318
Compare
Co-Authored-By: Federico Pomi <[email protected]>
Co-Authored-By: Federico Pomi <[email protected]>
Closing due to inactivity. |
reopened this. @notdroll to review |
notdroll
reviewed
Jan 27, 2025
connectors/us/us-trust-agreement.md
Outdated
@@ -22,7 +22,7 @@ This Trust Agreement (this "**Agreement**") is entered into by the Grantor throu | |||
1. **Account** means an Address owned by a person(s) or entity(ies) and controlled through a private key(s). | |||
2. **Address** means a public key address on a Blockchain Network. | |||
3. **Beneficiary** means the individual or entity that is in control of the most recent Account owning the Property Token. In the event the Property Token has not yet been minted, or has been minted but has not yet been owned by any Account, the Beneficiary shall be the original Grantor. In the event ownership of the Property Token is fractionalized (as discussed further in **Sections 6.1. and 7.3.**), then the defined term Beneficiary as used in this Agreement shall apply to the various owners of the Property Token as a group. | |||
4. **Blockchain Network** means the blockchain network and the consensus blockchain for such network used to maintain records of ownership and management of the Property Token to which this Agreement is attached. The relevant blockchain network may change due to actions of the Beneficiary, including the wrapping of the Property Token to a different blockchain network or the minting of the Property Token on a different blockchain network. | |||
4. **Blockchain Network** means any distributed ledger technology network, including Layer 1 or Layer 2 solutions, used to maintain records of ownership and management of the Property Token to which this Agreement is attached. The relevant blockchain network may change due to actions of the Beneficiary, including the wrapping of the Property Token to a different blockchain network or the minting of the Property Token on a different blockchain network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed "including Layer 1 or Layer 2 solutions"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trust Agreement v3.6: Improve Clarity of Legal Language
This PR enhances the Fabrica Trust Agreement with improved clarity and precision around blockchain-based property ownership, particularly focusing on token custody scenarios and smart contract interactions.
Key Changes
1. Enhanced Token Custody Framework
a) Ownership-transferring contracts (e.g., multi-signature wallets) directly controlled by individuals/entities
b) Functional contracts (e.g., escrow, bridges, collateral) that don't automatically transfer ownership
2. Improved Technical Terminology
burn
andburnBatch
)3. Legal Language Refinements
4. Documentation Updates
Technical Details
The changes maintain flexibility for future blockchain implementations while providing precise legal framework for:
Testing
Related Changes
This PR is part of ongoing efforts to improve the clarity and precision of our legal framework while maintaining technical accuracy and flexibility for future implementations.