Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the WAST version #106

Merged
merged 11 commits into from
Jul 2, 2024
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ The results here-below were computed on January the 30th, 2024 with the followin
| tapestry | 5.8.3 |
| underscore | 1.97 |
| yasson | 3.0.3 |
| wast | 0.0.12.1 |
| wast | 0.0.13.2 |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change in the readme as this list of versions is meant to indicate what lib versions were tested on the charts on this page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library, which has just been added, has not been tested yet, and there is no performance data for this library in the chart. It seems that it can be updated.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair.


[All graphs and sheets are available in this google doc.][spreadsheet]

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ dependencies {
// QuickBuffers
implementation group: 'us.hebi.quickbuf', name: 'quickbuf-runtime', version: '1.4'
// wast
implementation group: 'io.github.wycst', name: 'wast', version: '0.0.12.1'
implementation group: 'io.github.wycst', name: 'wast', version: '0.0.13.2'

// Test
testImplementation group: 'junit', name: 'junit', version: '4.13.2'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,6 @@ public Object quickbuf_json() throws Exception {
@Benchmark
@Override
public Object wast() throws Exception {
return io.github.wycst.wast.json.JSON.parseObject(JSON_SOURCE().nextString(), JSON_SOURCE().pojoType(), ReadOption.UseJDKDoubleParser);
return io.github.wycst.wast.json.JSON.parseObject(JSON_SOURCE().nextString(), JSON_SOURCE().pojoType()/*, ReadOption.UseJDKDoubleParser*/);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either:

  • remove entirely the ReadOption.UseJDKDoubleParse part to show/suggest it's the normal default setup;
  • or, add a comment explaining why this is kept here but commented.

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public Object quickbuf_json() throws Exception {
@Override
public Object wast() throws Exception {
ByteArrayOutputStream baos = JsonUtils.byteArrayOutputStream();
io.github.wycst.wast.json.JSON.writeJsonTo(JSON_SOURCE().nextPojo(), baos, WriteOption.WriteDecimalUseToString);
io.github.wycst.wast.json.JSON.writeJsonTo(JSON_SOURCE().nextPojo(), baos/*, WriteOption.WriteDecimalUseToString*/);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been cleared

return baos;
}
}
Loading