Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix keyof method's recursion error when many keys used #988

Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix keyof method's recursion error when many keys used #988

merged 2 commits into from
Dec 23, 2024

Conversation

EltonLobo07
Copy link
Collaborator

@EltonLobo07 EltonLobo07 commented Dec 18, 2024 •
edited
Loading

Fixes: #982

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 18, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/valibot@988

commit: 75a68a8

@fabian-hiller fabian-hiller self-assigned this Dec 19, 2024
@fabian-hiller fabian-hiller added the fix A smaller enhancement or bug fix label Dec 19, 2024
@fabian-hiller
Copy link
Owner

Amazing work! Thank you Elton!

@fabian-hiller fabian-hiller merged commit f3aecd4 into fabian-hiller:main Dec 23, 2024
11 checks passed
@fabian-hiller
Copy link
Owner

v1.0.0-beta.10 is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabian-hiller fabian-hiller

Labels
fix A smaller enhancement or bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keyof on object with over 47 keys gives TS2589: Type instantiation is excessively deep and possibly infinite
2 participants
@EltonLobo07 @fabian-hiller