Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(json): added support for more schema and actions #962

Merged
merged 6 commits into from
Jan 8, 2025
Merged

feat(json): added support for more schema and actions #962

merged 6 commits into from
Jan 8, 2025

Conversation

MathurAditya724
Copy link
Contributor

  • Support for date schema
  • Support for time, dateTime, base64, URL, startsWith, endsWith, includes, nonEmpty Actions

@MathurAditya724 MathurAditya724 marked this pull request as ready for review December 6, 2024 15:41
fabian-hiller
fabian-hiller reviewed Dec 7, 2024
View reviewed changes
Copy link
Owner

@fabian-hiller fabian-hiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating this PR! I look forward to merging it in the next few weeks. Once we have the implementation figured out, we should continue updating the unit tests.

packages/to-json-schema/src/convertSchema.ts Outdated Show resolved Hide resolved
packages/to-json-schema/src/convertSchema.ts Outdated Show resolved Hide resolved
packages/to-json-schema/src/convertAction.ts Outdated Show resolved Hide resolved
@fabian-hiller fabian-hiller self-assigned this Dec 7, 2024
@fabian-hiller fabian-hiller added the enhancement New feature or request label Dec 7, 2024
@MathurAditya724 MathurAditya724 mentioned this pull request Dec 15, 2024
Closed
5 tasks
@fabian-hiller fabian-hiller added the priority This has priority label Dec 23, 2024
@fabian-hiller
Copy link
Owner

Hey, I have more time again and plan to merge this PR soon. Feel free to take a look at my comments and give me feedback. If you don't have much time right now, I can try to finish the PR.

@fabian-hiller
Copy link
Owner

I plan to review and merge this PR today or tomorrow.

@fabian-hiller fabian-hiller force-pushed the main branch 2 times, most recently from f41426c to d713dfe Compare January 4, 2025 00:55
@vercel Vercel
Copy link

vercel bot commented Jan 8, 2025

@MathurAditya724 is attempting to deploy a commit to the Valibot Team on Vercel.

A member of the Team first needs to authorize it.

@fabian-hiller
Copy link
Owner

I have already started to finalize this PR.

@MathurAditya724
Copy link
Contributor Author

I just removed the regex (starts_with, ends_with, includes) part, as we will not be able to support it now as per your previous comment

@MathurAditya724
Copy link
Contributor Author

Sorry if I have messed something up, that was not my intention.

@fabian-hiller
Copy link
Owner

Don't worry 😉

@fabian-hiller fabian-hiller merged commit c28feda into fabian-hiller:main Jan 8, 2025
1 check failed
@fabian-hiller
Copy link
Owner

v1.0.0-beta.4 of @valibot/to-json-schema is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabian-hiller fabian-hiller fabian-hiller left review comments

Assignees

@fabian-hiller fabian-hiller

Labels
enhancement New feature or request priority This has priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MathurAditya724 @fabian-hiller