Add export for any validation regex #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for valibot canceled.
|
Co-authored-by: Jacob Groß <[email protected]>
fabian-hiller
force-pushed
the
feat/export-regex
branch
from
3083d46 to
a6f405c
Compare
kurtextrem
reviewed
Oct 21, 2023
| @@ -7,7 +12,7 @@ | |||
| */ | |||
| export function isLuhnAlgo(input: string) { | |||
| // Remove any non-digit chars | |||
| const number = input.replace(/\D/gu, ''); | |||
| const number = input.replace(NON_DIGIT_REGEX, ''); | |||
There was a problem hiding this comment.
needs replaceAll here (could be automatically captured by https://github.com/fabian-hiller/valibot/pull/213/files unicorn/prefer-string-replace-all I think.
reason is: a global regex (/g) will set lastIndex to the last index where the regex stopped. Which means if string a is "abc1" and string b is "a", lastIndex will be set to e.g. 3, but string b has no index 3, so the regex now fails at all times.
If you want to avoid replaceAll, you'll need to call
NON_DIGIT_REGEX.lastIndex = 0 before calling the replace
kurtextrem
reviewed
Oct 21, 2023
| * [IPv4](https://en.wikipedia.org/wiki/IPv4) regex. | ||
| */ | ||
| // eslint-disable-next-line redos-detector/no-unsafe-regex -- false positive | ||
| export const IPV4_REGEX = /^(?:(?:25[0-5]|(?:2[0-4]|1\d|[1-9])?\d)\.?\b){4}$/u; |
There was a problem hiding this comment.
Suggested change
| export const IPV4_REGEX = /^(?:(?:25[0-5]|(?:2[0-4]|1\d|[1-9])?\d)\.?\b){4}$/u; | |
| export const IPV4_REGEX = /^(?:25[0-5]|(?:2[0-4]|1\d|[1-9]|)\d)(?:\.(?:25[0-5]|(?:2[0-4]|1\d|[1-9]|)\d)){3}$/u; |
|
v0.20.0 is now available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.