ccios improvements #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BEfore that a blanc .ccios file was causing issue because template was not defined
…h Swift 6 Swift 6 implicitly open existentials, causing issue with Swinject without those explicit types. See Swinject/Swinject#571 for more details
alexandre-pod
force-pushed
the
feature/fixes
branch
from
1d8a670 to
ce01f05
Compare
peyronc
reviewed
Feb 28, 2025
| @@ -19,4 +19,7 @@ class {{name}}ViewController: SharedViewController, {{name}}ViewContract { | |||
|
|
|||
| // MARK: - {{name}}ViewContract | |||
|
|
|||
| func configure(with viewModel: {{name}}ViewModel) { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
en soit optionnel, mais dans les autres on n'a pas de ligne en rab après la dernière fonction, on pourrait l'enlever
There was a problem hiding this comment.
d'ailleurs autre question
- est-ce qu'on passerait pas
{{name}}ViewContractdans une extension ? - je sais pas si ca vaut le coup de rajouter ou non le mark UIViewController avant le viewDidload
There was a problem hiding this comment.
- Je vais enlever le retour à la ligne en trop, il ne sert pas en effet.
- Pour le ViewContract, je ne suis pas fan de le mettre dans une extension car ce view controller a comme principale fonction de conformer a ce protocole. Après c'est bien qu'on soit tous d'accord sur ce point.
- C'est vrai qu'un MARK
UIViewControllerou alors un simpleLifecycleserait bien
peyronc
approved these changes
Feb 28, 2025
| @@ -19,4 +19,7 @@ class {{name}}ViewController: SharedViewController, {{name}}ViewContract { | |||
|
|
|||
| // MARK: - {{name}}ViewContract | |||
|
|
|||
| func configure(with viewModel: {{name}}ViewModel) { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
d'ailleurs autre question
- est-ce qu'on passerait pas
{{name}}ViewContractdans une extension ? - je sais pas si ca vaut le coup de rajouter ou non le mark UIViewController avant le viewDidload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here what has been changed in this PR:
.ccios.yml{{project_name}}will now be replaced by the name of the project instead of the name of the first target@MainActorhas been added to relevent files in Coordinator and Presenter templates to improve Swift 6 support