Expose more functions #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Bucket.ts # src/R2.ts
f2face
reviewed
Jan 16, 2025
| * @param objectKey | ||
| * @param expiresIn Expiration time in seconds. | ||
| */ | ||
| public async putObjectSignedUrl(objectKey: string, expiresIn: number): Promise<string> { |
There was a problem hiding this comment.
Isn't this just the same as the GET one? Or is it used when you want to put an object and then retrieve the signed URL?
There was a problem hiding this comment.
from the docs it seems like the GET and POST ones are different URLs. So it's used to generate a signed URL where you can PUT an object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose getting a signed URL for a put action.
Also, since maybe not everything should be included in the library, it would be nice to be able to extend functionality per project use-case by being able to use the S3Client for custom tasks -- thus I exposed it with unsafe.