[CT-1-2] hilt 추가, ktlint 추가, buildSrc 작성 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2-dependencies # Conflicts: # app/.gitignore # app/build.gradle.kts # app/src/androidTest/java/com/yessorae/chartrainer/ExampleInstrumentedTest.kt # app/src/main/AndroidManifest.xml # app/src/test/java/com/yessorae/chartrainer/ExampleUnitTest.kt # build.gradle.kts # data/build.gradle.kts # data/src/androidTest/java/com/yessorae/data/ExampleInstrumentedTest.kt # data/src/test/java/com/yessorae/data/ExampleUnitTest.kt # domain/build.gradle.kts # presentation/build.gradle.kts # presentation/src/androidTest/java/com/yessorae/presentation/ExampleInstrumentedTest.kt # presentation/src/test/java/com/yessorae/presentation/ExampleUnitTest.kt
nosorae
added
feature
settings
| ) | ||
| } | ||
| } | ||
| compileOptions { | ||
| sourceCompatibility = JavaVersion.VERSION_1_8 | ||
| targetCompatibility = JavaVersion.VERSION_1_8 | ||
| sourceCompatibility = JavaVersion.VERSION_17 |
There was a problem hiding this comment.
Q; 8에서 17로 변경할 때 어떤 이점이 있을까요?
There was a problem hiding this comment.
명확한 이점을 찾아 올린 것은 아닙니다.
compileDebugJavaWithJavac와 kaptGenerateStubsDebugKotlin 빌드에러를 해결하기 위해 수정했습니다.
에러내용:
Caused by: org.gradle.api.GradleException: 'compileDebugJavaWithJavac' task (current target is 1.8) and 'kaptGenerateStubsDebugKotlin' task (current target is 17) jvm target compatibility should be set to the same Java version.
Base automatically changed from
feature/ct-1-1-gitignore-and-module
to
feature/ct-1-initial-project-setup
May 11, 2024 11:45
f-lab-nathan
merged commit 6ef5982
into
feature/ct-1-initial-project-setup
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2
CT-1-1 PR을 먼저 보시는 게 흐름상 맞습니다.