elfmalloc: Remove background cleanup thread #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Store a crossgeam GC collector in the BagPipe - Use this GC instance for pinning, eliminating the dependency on the global singleton, and thus on thread-local storage - elfmalloc: Don't set bsalloc as the global allocator because the new GC allocates on clone, and if the global allocator is bsalloc, each clone call becomes very expensive, which makes tests run very slowly - elfmalloc: Use opt-level=3 for tests in Travis - elfc: Set bsalloc as the global allocator
- Now that bagpipes don't rely on TLS, we can safely clean up thread-local caches while they are being dropped rather than sending pointers to a dedicated background thread
joshlf
force-pushed
the
elfmalloc-new-bagpipe
branch
from
652e6a3 to
14b7640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that bagpipes don't rely on TLS, we can safely clean up thread-local caches while they are being dropped rather than sending pointers to a dedicated background thread.