Raise informative errors for CWT misuse instead of opaque crashes - #171
Merged
Conversation
Closes #41. Two guards: - CWTTransformer rejects input that already carries a 'freq' dim, instead of failing inside AxisArray with 'dims contains repeated dim names'. - filterbank rejects complex kernels when min_phase != NONE, explaining that scipy.signal.minimum_phase only supports real filters (so complex/analytic wavelets like 'cmor' cannot be min-phased), instead of scipy's bare 'Complex filters not supported'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41.
Both failure modes from the issue are unchanged in current code and fail deep inside internals with messages that don't point at the actual problem. This PR adds two early guards:
CWTTransformerrejects input that already carries afreqdim. Previously this crashed inAxisArraywithdims contains repeated dim names; now it explains that CWT appends afreqaxis and expects time-domain input.filterbankrejects complex kernels whenmin_phase != NONE. Previously scipy raised a bareComplex filters not supported; now the error explains thatscipy.signal.minimum_phaseonly accepts real filters, so complex/analytic wavelets (e.g.cmor) cannot be min-phased — useMinPhaseMode.NONEor a real wavelet.Both scenarios from the original report have regression tests.