Slicer: select channels by regex against CoordinateAxis labels - #170
Merged
Conversation
Closes #61. parse_slice already matched comma-separated tokens exactly against axis labels; non-numeric tokens that fail an exact match are now compiled as regular expressions and full-matched against the labels, resolving to integer indices at reset time as before. A token that matches nothing raises an informative ValueError instead of an int-parse error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61.
parse_slicealready matched comma-separated tokens exactly againstCoordinateAxislabels. This PR adds the remaining half of the request: non-numeric tokens that fail an exact match are compiled as regular expressions and full-matched against the labels, e.g.:As sketched in the issue, patterns resolve to integer indices once at reset time and are cached in
SlicerState; per-chunk cost is unchanged.re.fullmatchsemantics:"Fp"does not match"Fp1"— use"Fp.*".ValueErrorinstead of an int-parse error.:parse as slices, so regexes cannot contain:.