Add new settings for timeout and max_samples so we can awake on data. - #38
Merged
Conversation
… Call pull from asyncio to_thread. Reduces CPU usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables a significant reduction in CPU usage.
self._pullis called inasyncio.to_threadso time spent in liblsl does not blockpull_timeout(defaults to 0.005) to spend more time in no-GIL liblslmax_pull_samples(defaults to None) to no-GIL wait for liblsl to return that many samples.pull_timeoutandmax_pull_samplesare provided, the call to pull will return when either condition is hit.