Do not block on first pull when timestamp processing enabled. - #36
Merged
Conversation
…ocksync init) which can occupy the event-loop thread for tens of ms and stall a co-located outlet. Run pulls on a worker thread (liblsl releases the GIL via ctypes) UNTIL the first data arrives — absorbing the warmup off the loop — then pull inline (non-blocking) so steady state has zero per-pull thread-hop overhead regardless of stream rate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First data triggers liblsl's proc_ALL warmup (dejitter/monotonize/ clocksync init) which can occupy the event-loop thread for tens of ms and stall a co-located outlet. Run pulls on a worker thread (liblsl releases the GIL via ctypes) UNTIL the first data arrives — absorbing the warmup off the loop — then pull inline (non-blocking) so steady state has zero per-pull thread-hop overhead regardless of stream rate.