Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to find dates #405

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

andremacola
Copy link
Contributor

I was having trouble on some sites like: https://atual7.com/noticias/politica/2024/10/brandao-e-camarao-retomam-conversas-governador-pode-disputar-senado-em-2026-e-vice-camara/ to extract dates.

I created a function that searches the body of the content for publication dates if the date was not found in the meta tags.

New tests have been created.

@ndaidong
Copy link
Collaborator

@andremacola thank you, let me see.

@ndaidong ndaidong changed the base branch from main to 8.0.13 October 18, 2024 16:10
@ndaidong ndaidong merged commit ec121f9 into extractus:8.0.13 Oct 18, 2024
5 checks passed
ndaidong added a commit that referenced this pull request Oct 18, 2024
- Merge pr #405 by @andremacola
@ndaidong ndaidong mentioned this pull request Oct 18, 2024
@ndaidong
Copy link
Collaborator

@andremacola I've merged your pr. It's amazing, thank you.

When you have free time, please take a look at these modules, we may borrow some more ideas 😃

ndaidong added a commit that referenced this pull request Oct 19, 2024
- Fix inconsistent output (#407)
- Modify some stuff at LdJson extraction (#405)
  - Only use value from LdJson if missed from meta tags
  - Only accept string value from LdJson
  - Stop converting LdJson value to lowercase
@ndaidong ndaidong mentioned this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants