Feat: extract pagetype from og:type or ld+json #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andremacola thank you, I will check and merge this soon. |
ndaidong
added a commit
that referenced
this pull request
Dec 5, 2023
- Merge pr #374 by @andremacola (issue #373) - Update dependencies - Update CI config - Fix function call in eval.js
Merged
Merged
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue #373 and includes several improvements:
1 - Refactoring of extractMetaData to avoid repetition and enhance maintainability.
2 - Adds extraction of JSON+LD Schema for certain parameters such as description, image, author, published and type in case they are not found by extractMetaData. This provides an additional extraction option for these parameters.
3 - Opens up the possibility to enhance and expand the extraction of other parameters through the JSON+LD Schema.
4 - Adds a test for extractLDSchema.
5 - Adds the OG:TYPE meta tag based on https://schema.org/docs/full.html (returns only types related to articles, blogs, and websites).
No external dependencies were used, only the logic from the article-extractor itself.