Enable wolf single thread opt #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec9cdb7. When enabling multi thread previously, we enabled it unconditionally. This is not desired, since we lose single thread optimizations for apps which is running in single threaded mode. This commit reverts and proper enabling will be done in further commits.
This reverts commit 6fae65b. To enable RW_THREADED only in multithreaded environments.
- disable wolfssl single threaded optimizations when compiling for multithreaded. - enable WOLFSSL_RW_THREADED
|
We need to also set singlethread for android Line 24 in 9e867a4 |
Single threaded is the default now And only for multi-thread projects, we override it with Please let me know if I miss something. |
xv-raihaan-m
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up of #188
When we enable parallel read/write support earlier, we disable single thread optimisations completely
This is not desired. Platforms which still use single thread should still be able to use with --disable-single-thread
Motivation and Context
To make platforms/apps decide whether to use single/multi thread support
How Has This Been Tested?
Verified unit tests
Types of changes
Checklist:
main