Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify the security process in the triage role #6217

Merged
merged 1 commit into from
Dec 20, 2024
Merged

docs: clarify the security process in the triage role #6217

merged 1 commit into from
Dec 20, 2024

Conversation

bjohansebas
Copy link
Member

As discussed in the recent TC meeting, it is important to clarify what to do as a triager regarding security matters.

cc: @expressjs/express-tc @expressjs/triagers

UlisesGascon
UlisesGascon approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think that this covers what we had discussed in our last meeting, also the triage team has limit rights to delete issues, so this is the best approach (IMO)

@UlisesGascon UlisesGascon requested review from a team December 13, 2024 14:08
mertcanaltin
mertcanaltin approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sushmeet
Sushmeet approved these changes Dec 14, 2024
View reviewed changes
Copy link

@Sushmeet Sushmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

carpasse
carpasse approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@carpasse carpasse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UlisesGascon
Copy link
Member

As this was already discussed in a TC Meeting and it is aligned with that discussion, I will merge the PR 👍

@UlisesGascon UlisesGascon merged commit 43020ff into expressjs:master Dec 20, 2024
2 checks passed
@bjohansebas bjohansebas deleted the triage-and-security branch December 20, 2024 19:22
yash-882 pushed a commit to yash-882/express that referenced this pull request Jan 27, 2025
@bjohansebas @yash-882
docs: clarify the security process in the triage role (expressjs#6217)
3d169ea
@bjohansebas bjohansebas mentioned this pull request Mar 15, 2025
Closed
@UlisesGascon UlisesGascon mentioned this pull request Mar 23, 2025
Closed
68 tasks
@wesleytodd wesleytodd mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carpasse carpasse carpasse approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@Sushmeet Sushmeet Sushmeet approved these changes

@IamLizu IamLizu IamLizu approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bjohansebas @UlisesGascon @carpasse @Sushmeet @IamLizu @mertcanaltin