update node version #474
Closed
update node version #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are going to update everything in next major release which is currently under development |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
I am updating the required node version to 20.10.0 and removing node-sass in favor of sass
Why:
The build and publish seems to be failing. I think it's because the version of node we were using is long dead and there were warnings about the version of node. We'll see if the fix is as simple as updating node.
How:
Simply bumped the version of node in .npmrc, uninstalled node-sass, ran true-level, and then installed sass. I ran build, test, lint, and started the app locally to see if it all still worked.
Checklist: