Skip to content

Commit

Permalink
fix: RTL support (#267)
Browse files Browse the repository at this point in the history
* add RTL example

* add quickfix

makes the carousel functional, but just via overriding the direction

* internal rtl support

relying on a global attribute selector feels a bit hacky

* fix import

* simplify style

* include dot group in rtl example for demonstration purposes

* lint
  • Loading branch information
seleb authored Apr 23, 2020
1 parent c1ba944 commit 10edf2d
Show file tree
Hide file tree
Showing 6 changed files with 88 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/App/App.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
Example11,
Example12,
Example13,
Example14,
} from './examples';
import s from './style.scss';

Expand Down Expand Up @@ -247,6 +248,13 @@ class DevelopmentApp extends React.Component {
</section>
)}

{(value === '0' || value === '14') && (
<section id="example--14">
<hr />
<Example14 />
</section>
)}

</div>
</div>
</div>
Expand Down
66 changes: 66 additions & 0 deletions src/App/examples/Example14/Example14.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
import React from 'react';
import
{
ButtonBack,
ButtonFirst,
ButtonLast,
ButtonNext,
CarouselProvider,
Slide,
Slider,
ImageWithZoom,
DotGroup,
} from '../../..';

import s from '../../style.scss';

export default () => (
<CarouselProvider
visibleSlides={2}
totalSlides={8}
step={1}
naturalSlideWidth={400}
naturalSlideHeight={500}
>
<h2 className={s.headline}>RTL</h2>
<p>
A carousel wrapped in an element with
{' '}
<code>dir=&quot;rtl&quot;</code>
, demonstrating support for use with right-to-left languages.
</p>
<div dir="rtl">
<Slider className={s.slider}>
<Slide index={0}>
<ImageWithZoom src="./media/img01.jpeg" />
</Slide>
<Slide index={1}>
<ImageWithZoom src="./media/img02.jpeg" />
</Slide>
<Slide index={2}>
<ImageWithZoom src="./media/img03.jpeg" />
</Slide>
<Slide index={3}>
<ImageWithZoom src="./media/img04.jpeg" />
</Slide>
<Slide index={4}>
<ImageWithZoom src="./media/img05.jpeg" />
</Slide>
<Slide index={5}>
<ImageWithZoom src="./media/img06.jpeg" />
</Slide>
<Slide index={6}>
<ImageWithZoom src="./media/img07.jpeg" />
</Slide>
<Slide index={7}>
<ImageWithZoom src="./media/img08.jpeg" />
</Slide>
</Slider>
<ButtonFirst>First</ButtonFirst>
<ButtonBack>Back</ButtonBack>
<ButtonNext>Next</ButtonNext>
<ButtonLast>Last</ButtonLast>
<DotGroup dotNumbers />
</div>
</CarouselProvider>
);
3 changes: 3 additions & 0 deletions src/App/examples/Example14/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import Example14 from './Example14';

export default Example14;
1 change: 1 addition & 0 deletions src/App/examples/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ export { default as Example10 } from './Example10';
export { default as Example11 } from './Example11';
export { default as Example12 } from './Example12';
export { default as Example13 } from './Example13';
export { default as Example14 } from './Example14';
5 changes: 5 additions & 0 deletions src/Slide/Slide.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@

&Horizontal {
float: left;

[dir='rtl'] & {
direction: rtl;
transform: scaleX(-1);
}
}

&Inner {
Expand Down
5 changes: 5 additions & 0 deletions src/Slider/Slider.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
position: relative;
overflow: hidden;

[dir='rtl'] & {
direction: ltr;
transform: scaleX(-1);
}

&Tray {
overflow: hidden;
width: 100%;
Expand Down

0 comments on commit 10edf2d

Please sign in to comment.