-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ClangIR Protobuf Deserializer #27
base: main
Are you sure you want to change the base?
Conversation
Build is failing right now, but this is to be expected: |
You can change the ClangIR version using on CI here. |
e023991
to
b121615
Compare
CIRRecordKind_Class = 0; | ||
CIRRecordKind_Union = 1; | ||
CIRRecordKind_Struct = 2; | ||
RecordKind_Class = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think the name change is necessary? It breaks the backward compatibility of the protocol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it's still work in progress, I assumed such changes would not create big issues. I introduced them to create uniform naming style for Enum values, so code generators can hold simpler logic. I can put the old names back, but it may complicate TableGen backends and its future maintenance.
No description provided.