forked from hiero-ledger/hiero-sdk-python
-
Notifications
You must be signed in to change notification settings - Fork 4
ci: add fuzz and tck support to test file naming #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
exploreriii
wants to merge
7
commits into
main
Choose a base branch
from
test-naming
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1a2df25
ci: add fuzz and tck support to test file naming
exploreriii fe0c3a4
fix: fetch main
exploreriii 0a256c5
fix: coderabbit
exploreriii f803a76
test: bad test name - should fail
exploreriii 7916d73
feat: expand to check for all tests
exploreriii 8c0a7d4
chore: improve UI
exploreriii 5c20412
fix: grab file name in console
exploreriii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| const { execSync } = require("child_process"); | ||
|
|
||
| // These are the directories we want to check for correct naming | ||
| const TEST_DIRS = ["tests/unit", "tests/integration", "tests/tck", "tests/fuzz"]; | ||
|
|
||
| // These are the excluded paths and file names inside the TEST_DIRS | ||
| const IGNORED = ["tests/fuzz/support"]; | ||
| const EXCEPTIONS = ["conftest.py", "__init__.py", "init.py", "mock_server.py", "utils.py"]; | ||
|
|
||
| // Collect naming errors to report at the end | ||
| const name_errors = []; | ||
|
|
||
| // Get list of changed files compared to main | ||
| const output = execSync("git diff --name-only origin/main...HEAD", { encoding: "utf-8" }); | ||
| // Split output into lines and filter out empty lines for easy manipulation | ||
| // e.g. output = "tests/unit/my_test.py\ntests/integration/other_test.py" | ||
| const files = output.split("\n").filter(Boolean); | ||
|
exploreriii marked this conversation as resolved.
Outdated
|
||
|
|
||
|
|
||
| for (const file of files) { | ||
| // --- PATH FILTERING --- | ||
| // Skip files that are not in any of the specified test directories | ||
| if (!TEST_DIRS.some(dir => file.startsWith(dir))) continue; | ||
|
|
||
| // Skip ignored paths (e.g. helpers) | ||
| if (IGNORED.some(path => file.startsWith(path))) continue; | ||
|
|
||
| // Now we have file paths that we need to check for correct naming | ||
| // e.g. file = "tests/unit/my_test.py" | ||
|
|
||
| // --- Correct PATH now apply NAMING checks --- | ||
|
|
||
| // Extract the file name from the path | ||
| // e.g. from file = "tests/unit/my_test.py" get name = "my_test.py" | ||
| const name = file.split("/").pop(); | ||
|
|
||
| // Skip allowed special files | ||
| if (EXCEPTIONS.includes(name)) continue; | ||
|
|
||
| // Enforce naming rule on files | ||
| if (!name.endsWith("_test.py")) { | ||
| console.error(`::error file=${file}::Must end with '_test.py'`); | ||
| name_errors.push(file); | ||
| } | ||
| } | ||
|
|
||
| // Fail if any bad files found | ||
| if (name_errors.length > 0) { | ||
| console.error("\nInvalid test files:"); | ||
| name_errors.forEach(f => console.error(`- ${f}`)); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| console.log("All test filenames are valid"); | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.