-
Notifications
You must be signed in to change notification settings - Fork 98
Project 3 #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
deekshithanantha
wants to merge
43
commits into
expertiza:main
Choose a base branch
from
deekshithanantha:project_3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Project 3 #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… create Tabbed columns
src/pages/Assignments/
├── Assignment.tsx (main file - now much cleaner!)
└── tabs/
├── GeneralTab.tsx
├── TopicsTab.tsx
├── RubricsTab.tsx
├── ReviewStrategyTab.tsx
├── DueDatesTab.tsx
└── EtcTab.tsx
…ck on what is satisfied and what is not satisfied
…nted to the backend data
- Implemented fetching of topics based on the selected assignment ID. - Enhanced the UI to display loading states and error messages for topic retrieval. - Updated the table to show available topics with their respective slots and waitlist counts. - Added functionality for user-selected topics display and highlighting. - Refactored code for better readability and maintainability.
- Added functionality to store and utilize the database ID for topics in API calls. - Implemented success and error handling for topic edits, including alerts for users. - Updated the UI to log actions and provide feedback during topic editing and deletion. - Refactored code for improved clarity and maintainability in topic management.
- Added state management for bookmarking and selecting topics. - Introduced UI elements for toggling bookmarks and selections with appropriate icons. - Updated topic rendering to reflect bookmark and selection states. - Enhanced user experience by visually distinguishing taken, selected, and bookmarked topics.
- Implemented API call for dropping teams from topics with error handling and success alerts. - Updated UI to reflect team assignment status, including improved rendering for assigned and waitlisted teams. - Enhanced topic selection logic in StudentTasks to support single selection and automatic drop of previously selected topics. - Added loading indicators during sign-up processes and improved user feedback for actions taken on topics.
…ency - Removed unused imports and streamlined icon usage. - Updated member display logic to always show names in admin view. - Enhanced rendering of assigned and waitlisted teams, including clearer messaging for unassigned topics. - Improved overall layout and readability of team information in the UI.
- Updated alignment of task items to center for better visual appeal. - Changed width of the topics container to fit-content for a more responsive design. - Added padding to table headers and cells for enhanced readability. - Removed inline styles from table cells to streamline styling.
- Added padding to table headers and cells for enhanced visual clarity. - Centered text in specific columns to improve layout consistency. - Streamlined row rendering logic for better maintainability. - Updated comments for clarity on styling choices.
- Changed the filled bookmark icon color to beige/tan for better visibility. - Restored the outline bookmark icon color to muted gray for a cohesive design. - Removed unnecessary comments regarding image path updates for clarity.
…nality and UI consistency - Introduced AssignmentEditPage for editing assignments with a dedicated route. - Updated App component to include new edit route for assignments. - Enhanced Assignment component to utilize a table for displaying assignments with improved data handling. - Streamlined TopicsTab and TopicsTable components for better organization and readability. - Improved StudentTasks layout to utilize TopicsTable for displaying topics, allowing for better interaction and visual clarity. - Removed deprecated code and unnecessary comments for cleaner implementation.
…udentTasks - Implemented API calls for creating, updating, and deleting topics with success and error alerts. - Added optimistic UI updates in StudentTasks for better user experience during topic selection and dropping. - Introduced new state management for optimistic slot changes to reflect real-time availability of topics. - Improved styling for selected rows in the table to enhance visual feedback for user interactions.
…d data management - Modified topic ID handling to ensure consistent data types across API calls. - Enhanced the delete and edit topic functions to utilize database IDs for better accuracy. - Updated UI interactions in TopicsTab to streamline topic editing and partner ad applications. - Improved comments and code clarity for better maintainability.
…t and deletion handling
…mponents - Introduced optimistic UI updates for topic selection and deselection, improving user experience during interactions. - Updated state management to handle UI-selected topics, pending deselections, and optimistic selections for better data consistency. - Modified table rendering logic to apply background color styling for selected rows, enhancing visual feedback. - Ensured database IDs are used for API calls related to topic management, improving accuracy in data handling.
- Implemented drop team request in AssignmentEditPage, allowing teams to be removed from topics. - Added success and error handling for drop team actions with user alerts. - Refactored TopicsTab to utilize database IDs for topic management, enhancing data accuracy. - Removed unused state for displaying user names and cleaned up commented code for better readability.
- Added waitlist functionality to TopicsTable, displaying a "Waitlisted" badge for students. - Updated selection logic in StudentTasks to account for waitlisted status, improving user feedback. - Enhanced aria-labels for buttons to provide clearer accessibility information regarding topic selection and waitlisting. - Refactored state management to ensure accurate representation of user status on topics.
- Updated team display structure to improve layout and spacing. - Replaced the delete icon with a button for better accessibility and user experience. - Enhanced button functionality with a tooltip for clearer action indication.
…used FontAwesome icons from AssignmentEditor
…able, and update the reviewer link destination.
9b92d8d to
48b6b0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.