-
Notifications
You must be signed in to change notification settings - Fork 172
Advertisements and JoinTeamRequests #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vihar2712
wants to merge
28
commits into
main
Choose a base branch
from
advertisements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrect data to frontend
added create student team method inside student_teams controller modified logic of participant accepting invitation modified serializer
added from_participant reference inside invitations schema modified retract invitations functionality team serializer now takes participant serializer added more validations inside invitation validator
…student_teams controller and added corresponding routes added advertisement related fields inside signedup teams table
* single action_allowed? method implemented * Review and validate the existing controller methods, ensuring they are properly integrated with the frontend. * common database * signup data * joining team requests implemented * adding data for the requests and joins * Implement email notifications for accepted join team requests and invitations * adding test cases * test case integrated * axios * fix change teams * Model tests * removed /api/v1 nomenclature from the system (#210) * removed /api/v1 nomenclature from the system * modified Dangerfile * Ndt2000 patch 1 (#215) * Update TestPR.yml Updated the Ruby version to 3.4.5 * Update danger.yml * Ruby version updated * Ruby version updated * Ruby version update * Solution for failing tests * Solution for failing tests * Solution for failing CI/CD tests * Solution for failing CI/CD tests * Solution for failing CI/CD tests * Solution for failing CI/CD tests * Solution for failing CI/CD tests * Solution for failing CI/CD tests * Pipeline test rewritten * yml file update for new version compatibility * Workflow test changes * Workflow test changes * Workflow test changes * Workflow test changes * Workflow test changes * Changed Rails Version (#211) * Changed Rails Version * Update danger.yml * Update danger_target.yml * Update TestPR.yml * Update main.yml * Update danger_target.yml * Update main.yml * Update danger.yml * Updated ruby version to 3.4.5 * E2555: Backend for Participants page (#222) * fix: join assignment participant with user when GET participants/assignment/:assignment_id for 2555 * fix: fix seed script to create Role first * fix: make students have parent id randomly inside seeds.rb --------- Co-authored-by: Ash Zahabiuon <[email protected]> * Added teams columns like shown on the website * Added the columns we were required to in teams --------- Co-authored-by: Vihar Shah <[email protected]> * Finish Grades controller (#229) * Pending changes exported from your codespace * grades controller finished * converted the methods to calculate avg review grade into a mixin. added null handling in case of calculating avg peer score * added comments inside grades_controller file * fixed action_allowed inside grades_controller added test cases for grades controller changed routes and methods for assigning grades * fixed syntax errors due to merging * fixed analyitc issue, linting errors, spelling errors * question changed to item fixed almost all test cases. * removed max_team_size and user reference from team class removed tests for invitations_controller. will handle inside that branch fixed all other test files * added comments inside grades_controller.rb * grades controller finished * team hierarchy still unresolved. authorization module included. * /api/v1 removed * modified invitation model * modified student_teams controller - made use of serializer, sending correct data to frontend * methods inside student_teams added * retract, accept, reject invitation working * added authorization inside invitations controller added create student team method inside student_teams controller modified logic of participant accepting invitation modified serializer * modified invitations controller added from_participant reference inside invitations schema modified retract invitations functionality team serializer now takes participant serializer added more validations inside invitation validator * added invitations sent by participant route and method * added methods for performing crud operations on advertisement inside student_teams controller and added corresponding routes added advertisement related fields inside signedup teams table * single action_allowed? method implemented * Review and validate the existing controller methods, ensuring they are properly integrated with the frontend. * signup data * joining team requests implemented * Implement email notifications for accepted join team requests and invitations * test case integrated * axios * fix change teams * Model tests --------- Co-authored-by: vatsal-dp <[email protected]> Co-authored-by: devyash2930 <[email protected]> Co-authored-by: smitraval24 <[email protected]> Co-authored-by: Nayan Taori <[email protected]> Co-authored-by: Prithish Samanta <[email protected]> Co-authored-by: Seojin Kim <[email protected]> Co-authored-by: Ash Zahabiuon <[email protected]> Co-authored-by: SpencerKersey <[email protected]>
…orrect data to frontend
added create student team method inside student_teams controller modified logic of participant accepting invitation modified serializer
added from_participant reference inside invitations schema modified retract invitations functionality team serializer now takes participant serializer added more validations inside invitation validator
…student_teams controller and added corresponding routes added advertisement related fields inside signedup teams table
Generated by 🚫 Danger |
|
🚨 RSpec Tests Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.