Advertisements and JoinTeamRequests #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e properly integrated with the frontend.
* removed /api/v1 nomenclature from the system * modified Dangerfile
* Update TestPR.yml Updated the Ruby version to 3.4.5 * Update danger.yml * Ruby version updated * Ruby version updated * Ruby version update * Solution for failing tests * Solution for failing tests * Solution for failing CI/CD tests * Solution for failing CI/CD tests * Solution for failing CI/CD tests * Solution for failing CI/CD tests * Solution for failing CI/CD tests * Solution for failing CI/CD tests * Pipeline test rewritten * yml file update for new version compatibility * Workflow test changes * Workflow test changes * Workflow test changes * Workflow test changes * Workflow test changes
* Changed Rails Version * Update danger.yml * Update danger_target.yml * Update TestPR.yml * Update main.yml * Update danger_target.yml * Update main.yml * Update danger.yml * Updated ruby version to 3.4.5
* fix: join assignment participant with user when GET participants/assignment/:assignment_id for 2555 * fix: fix seed script to create Role first * fix: make students have parent id randomly inside seeds.rb --------- Co-authored-by: Ash Zahabiuon <[email protected]>
* Added the columns we were required to in teams --------- Co-authored-by: Vihar Shah <[email protected]>
* Pending changes exported from your codespace * grades controller finished * converted the methods to calculate avg review grade into a mixin. added null handling in case of calculating avg peer score * added comments inside grades_controller file * fixed action_allowed inside grades_controller added test cases for grades controller changed routes and methods for assigning grades * fixed syntax errors due to merging * fixed analyitc issue, linting errors, spelling errors * question changed to item fixed almost all test cases. * removed max_team_size and user reference from team class removed tests for invitations_controller. will handle inside that branch fixed all other test files * added comments inside grades_controller.rb
…orrect data to frontend
added create student team method inside student_teams controller modified logic of participant accepting invitation modified serializer
added from_participant reference inside invitations schema modified retract invitations functionality team serializer now takes participant serializer added more validations inside invitation validator
…student_teams controller and added corresponding routes added advertisement related fields inside signedup teams table
…e properly integrated with the frontend.
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.