E2550 Response hierarchy and responses_controller back end #227
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| class ResponsesController < ApplicationController | ||
| before_action :set_response, only: [:update, :submit, :unsubmit, :destroy] | ||
|
|
||
| # Authorization: determines if current user can perform the action | ||
| def action_allowed? | ||
| case action_name | ||
| when 'create' | ||
| true | ||
| when 'update', 'submit' | ||
| @response = Response.find(params[:id]) | ||
| unless response_belongs_to? || has_privileges_of?('Instructor') || has_privileges_of?('Admin') | ||
| render json: { error: 'forbidden' }, status: :forbidden | ||
| end | ||
| when 'unsubmit', 'destroy' | ||
| unless has_privileges_of?('Instructor') || has_privileges_of?('Admin') | ||
| render json: { error: 'forbidden' }, status: :forbidden | ||
| end | ||
| else | ||
| render json: { error: 'forbidden' }, status: :forbidden | ||
| end | ||
| true | ||
| end | ||
|
|
||
| # POST /responses | ||
| def create | ||
| @response_map = ResponseMap.find_by(id: params[:response_map_id] || params[:map_id]) | ||
| return render json: { error: 'ResponseMap not found' }, status: :not_found unless @response_map | ||
|
|
||
| @response = Response.new( | ||
| map_id: @response_map.id, | ||
| is_submitted: false, | ||
| created_at: Time.current | ||
| ) | ||
|
|
||
| if @response.save | ||
| render json: { message: 'Response draft created successfully', response: @response }, status: :created | ||
| else | ||
| render json: { error: @response.errors.full_messages.to_sentence }, status: :unprocessable_entity | ||
| end | ||
| end | ||
|
|
||
| # PATCH /responses/:id | ||
| # Reviewer edits existing draft (still unsubmitted) | ||
| def update | ||
| puts "Updating Response ID: #{params[:id]}" | ||
| return render json: { error: 'forbidden' }, status: :forbidden if @response.is_submitted? | ||
|
|
||
| if @response.update(response_params) | ||
| render json: { message: 'Draft updated successfully', response: @response }, status: :ok | ||
| else | ||
| render json: { error: @response.errors.full_messages.to_sentence }, status: :unprocessable_entity | ||
| end | ||
| end | ||
|
|
||
| # PATCH /responses/:id/submit | ||
| # Lock the response and calculate final score | ||
| def submit | ||
| return render json: { error: 'User response not found' }, status: :not_found unless @response | ||
| if @response.is_submitted? | ||
| return render json: { error: 'User has already submitted the response' }, status: :unprocessable_entity | ||
| end | ||
| # Check deadline | ||
| unless submission_window_open?(@response) | ||
| return render json: { error: 'Deadline has passed' }, status: :forbidden | ||
| end | ||
|
|
||
| # Validate rubric completion | ||
| unanswered = @response.scores.select { |a| a.answer.nil? } | ||
| unless unanswered.empty? | ||
| return render json: { error: 'All rubric items must be answered' }, status: :unprocessable_entity | ||
| end | ||
|
|
||
| # Lock response | ||
| @response.is_submitted = true | ||
|
|
||
| # Calculate score via ScorableHelper | ||
| total_score = @response.aggregate_questionnaire_score | ||
|
|
||
| if @response.save | ||
| render json: { | ||
| message: 'Response submitted successfully', | ||
| response: @response, | ||
| total_score: total_score | ||
| }, status: :ok | ||
| else | ||
| render json: { error: @response.errors.full_messages.to_sentence }, status: :unprocessable_entity | ||
| end | ||
| end | ||
|
|
||
| # PATCH /responses/:id/unsubmit | ||
| # Instructor/Admin reopens a submitted response | ||
| def unsubmit | ||
| return render json: { error: 'User response not found' }, status: :not_found unless @response | ||
|
|
||
| if @response.is_submitted? | ||
| @response.update(is_submitted: false) | ||
| render json: { message: 'User response has been unsubmitted', response: @response }, status: :ok | ||
| else | ||
| render json: { error: 'User response already unsubmitted' }, status: :unprocessable_entity | ||
| end | ||
| end | ||
|
|
||
| # DELETE /responses/:id | ||
| # Instructor/Admin deletes invalid/test response | ||
| def destroy | ||
| return render json: { error: 'User response not found' }, status: :not_found unless @response | ||
|
|
||
| @response.destroy | ||
| head :no_content | ||
| rescue StandardError => e | ||
| render json: { error: e.message }, status: :unprocessable_entity | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def set_response | ||
| @response = Response.find_by(id: params[:id]) | ||
| end | ||
|
|
||
| def response_params | ||
| params.require(:response).permit( | ||
| :map_id, | ||
| :is_submitted, | ||
| :submitted_at, | ||
| scores_attributes: [:id, :question_id, :answer, :comment] | ||
| ) | ||
| end | ||
|
|
||
| def response_belongs_to? | ||
| # Member actions: we have @response from set_response | ||
| return @response.map&.reviewer&.id == current_user.id if @response&.map&.reviewer && current_user | ||
|
|
||
| # Collection actions (create, next_action): check map ownership | ||
| map_id = params[:response_map_id] || params[:map_id] | ||
| return false if map_id.blank? | ||
|
|
||
| map = ResponseMap.find_by(id: map_id) | ||
| return false unless map | ||
|
|
||
| map.reviewer == current_user | ||
| end | ||
|
|
||
| # Returns true if the assignment's due date is in the future or no due date is set | ||
| def submission_window_open?(response) | ||
| assignment = response.respond_to?(:response_map) ? response.response_map&.assignment : nil | ||
| return true if assignment.nil? | ||
| return true if assignment.respond_to?(:due_dates) && assignment.due_dates.nil? | ||
| # if due_date responds to future? use it, otherwise compare to now | ||
| if assignment.respond_to?(:due_dates) && assignment.due_dates.respond_to?(:future?) | ||
| return assignment.due_dates.first.future? | ||
| end | ||
|
|
||
| # fallback: compare | ||
| due = assignment.due_dates | ||
| return true if due.nil? | ||
|
|
||
| puts "Checking deadline: due_at=#{due.inspect}, current_time=#{Time.current}" | ||
| due.first.due_at > Time.current | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is just WRONG to build into the mechanism that ALL rubric items must have text (or numbers) entered for ALL rubrics of ANY KIND anywhere in the system. This should be dependent on policy. Remove this check.