PR from E2552 to E2557 #223
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| ruby-3.4.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| class ProjectTopicsController < ApplicationController | ||
| before_action :set_project_topic, only: %i[ show update ] | ||
|
|
||
| # GET /project_topics?assignment_id=&topic_ids[]= | ||
| def index | ||
| if params[:assignment_id].nil? | ||
| render json: { message: 'Assignment ID is required!' }, status: :unprocessable_entity | ||
| else | ||
| @project_topics = ProjectTopic.find_by_assignment_and_topic_ids(params[:assignment_id], params[:topic_ids]) | ||
| render json: @project_topics.map(&:to_json_with_computed_data), status: :ok | ||
| end | ||
| end | ||
|
|
||
| # POST /project_topics | ||
| def create | ||
| result = ProjectTopic.create_topic_with_assignment( | ||
| project_topic_params, | ||
| params[:project_topic][:assignment_id], | ||
| params[:micropayment] | ||
| ) | ||
|
|
||
| if result[:success] | ||
| render json: { message: result[:message] }, status: :created | ||
| else | ||
| render json: { message: result[:message] }, status: :unprocessable_entity | ||
| end | ||
| end | ||
|
|
||
| # PATCH/PUT /project_topics/1 | ||
| def update | ||
| result = @project_topic.update_topic(project_topic_params) | ||
|
|
||
| if result[:success] | ||
| render json: { message: result[:message] }, status: :ok | ||
| else | ||
| render json: { message: result[:message] }, status: :unprocessable_entity | ||
| end | ||
| end | ||
|
|
||
| # Show a ProjectTopic by ID | ||
| def show | ||
| render json: @project_topic, status: :ok | ||
| end | ||
|
|
||
| # Destroy ProjectTopics by assignment_id and optional topic_ids | ||
| def destroy | ||
| if params[:assignment_id].nil? | ||
|
Collaborator
There was a problem hiding this comment. don't need this check, the project topic always belong to an assignment |
||
| render json: { message: 'Assignment ID is required!' }, status: :unprocessable_entity | ||
| else | ||
| result = ProjectTopic.delete_by_assignment_and_topic_ids(params[:assignment_id], params[:topic_ids]) | ||
|
Collaborator
There was a problem hiding this comment. need to loop over all topic ids and call delete method for each topic id |
||
|
|
||
| if result[:success] | ||
| render json: { message: result[:message] }, status: :no_content | ||
| else | ||
| render json: { message: result[:message] }, status: :unprocessable_entity | ||
| end | ||
| end | ||
| end | ||
|
|
||
| private | ||
|
|
||
| # Use callbacks to share common setup or constraints between actions. | ||
| def set_project_topic | ||
| @project_topic = ProjectTopic.find(params[:id]) | ||
| end | ||
|
|
||
| # Only allow a list of trusted parameters through. | ||
| def project_topic_params | ||
| params.require(:project_topic).permit(:topic_identifier, :category, :topic_name, :max_choosers, :assignment_id, :description, :link) | ||
| end | ||
| end | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for micropayment field