Updates to KeyLookup #1527
Merged
Updates to KeyLookup #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes to make the KeyLookup work more seamlessly with Coop: - RPM source and TPM source can be different - You can update the KeyLookup builder from an external dict (makes it easier to integrate with custodial key data from the db)
We need to initialize a custom Coop object in the remote inference container
extract_service split the key into (RPM, DEEP, INFRA) instead of (RPM, DEEP_INFRA). This fix should rectify that issue
rbyh
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates make it easier to implement custodial keys on Coop