Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New QuestionDict, new nb for agent fatigue #1479

Merged
merged 15 commits into from
Jan 15, 2025
Merged

New QuestionDict, new nb for agent fatigue #1479

merged 15 commits into from
Jan 15, 2025

Conversation

rbyh
Copy link
Contributor

@rbyh rbyh commented Jan 10, 2025

No description provided.

@rbyh rbyh requested a review from johnjosephhorton January 10, 2025 19:23
@rbyh rbyh changed the title New nb for simulating agent fatigue New QuestionDict, new nb for agent fatigue Jan 10, 2025
@rbyh
Copy link
Contributor Author

rbyh commented Jan 10, 2025

Need to add test checking that len(value_types) = len(value_descriptions) = len(answer_keys) of either optimal field is present.

@rbyh rbyh marked this pull request as draft January 11, 2025 17:22
@rbyh rbyh marked this pull request as ready for review January 12, 2025 12:16
@rbyh
Copy link
Contributor Author

rbyh commented Jan 12, 2025

@arulmabr Do you have time to look over new QuestionDict? I used your excellent QuestionMatrix PR as my reference!
@zer0dss I think the same (new?) tests are failing - do you know what the issue is?
Thank you both!

@zer0dss
Copy link
Collaborator

zer0dss commented Jan 12, 2025

@rbyh I'm checking it.

@zer0dss
Copy link
Collaborator

zer0dss commented Jan 12, 2025

@rbyh The coopr tests are fixed now. But there is still this edsl side test that fails.
Screenshot 2025-01-12 at 14 58 50

@zer0dss
Copy link
Collaborator

zer0dss commented Jan 12, 2025

I think I've found the problem. I'm working on a fix.

@zer0dss
Copy link
Collaborator

zer0dss commented Jan 12, 2025

The class failes to multiple tests inside the test_QuestionDict.py test file.

@arulmabr
Copy link
Contributor

Hi @rbyh thanks!
Shall I play around this PR now or shall I wait till the tests are passing for 3.11?

@rbyh
Copy link
Contributor Author

rbyh commented Jan 13, 2025

@arulmabr Let me get those outstanding tests passing and then that would be great for you to take a look, thanks!

@rbyh rbyh marked this pull request as draft January 13, 2025 20:00
@rbyh rbyh marked this pull request as ready for review January 13, 2025 22:06
@rbyh
Copy link
Contributor Author

rbyh commented Jan 13, 2025

@arulmabr all set to take a look!

@arulmabr
Copy link
Contributor

@rbyh I did a comprehensive testing and created a notebook here - https://www.expectedparrot.com/content/a970e4f9-39ca-49eb-9f99-f72bf3ec4b28

It's perfect!

@rbyh rbyh requested review from onmyraedar and zer0dss and removed request for johnjosephhorton January 15, 2025 15:46
@zer0dss zer0dss merged commit 4c3c79a into main Jan 15, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants