Refactorings based on Steffan153's work #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires 0.1.81 before merging. |
vendethiel
reviewed
Oct 30, 2024
| if amount < 0: | ||
| die: 'amount must be greater than 0' | ||
| else: amount | ||
| reduce _ closed operations: |
There was a problem hiding this comment.
I think this is a net negative. This loses the spirit of the exercise. The tests need to adjusted.
vendethiel
reviewed
Oct 30, 2024
vendethiel
reviewed
Oct 30, 2024
|
|
||
| defn reverse(list): | ||
| core/reverse: list | ||
| list:reverse.reduce(function initial) |
There was a problem hiding this comment.
this is also not a good example of reimplementing the language in the language, though it already wasn't...
vendethiel
reviewed
Oct 30, 2024
| vector a: | ||
| if b > 9: (b - 9) b | ||
| digits =: value.replace(' ').map(\(_ - \\0)):reverse | ||
| digits.#.gt(1) &&: digits.every?(\(0 <= _ <= 9)) && |
There was a problem hiding this comment.
fair for now, but also a bit of hack because of no precedence
vendethiel
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are now the best known yamlscript solutions.