Skip to content

Conversation

meatball133
Copy link
Member

Includes:

  • Raindrops
  • Resistor color
  • Resistor color duo
  • Resistor color trio
  • Reverse string
  • Rna transcription

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

value_copy /= 1000
index += 1
end
"#{value_copy} #{LABELS[index]}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to understand why the example files are changed here...

I thought this was about templates, and example files are not generally given by the upstream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem spec added tests which were not coverd by the original example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should likely be a patch outside of this patch-set then.

Thanks for doing the work for the additional (breaking changes, I presume) functionality for the example.rb file though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants