-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 Add stub files to all exercises #401
Conversation
7408927
to
228292c
Compare
@m-dango Well, it's not only that the stub files have to be in place, but also that the paths in the exercises' |
Many of the filenames will change as the generator creates them to match the file patterns in config.json. e.g. The changes in exercises/practice/secret-handshake/.meta/config.json for example will need to be undone. Looking a bit closer, it seems that something has gone wrong with the |
Ah okay. I would then suggest to close this PR and wait for the other PRs to fix the issue of missing stubs. Agreed? |
@ErikSchierboom I'm moving house roughly in the next couple weeks so I'm not too sure unfortunately. There is currently an outstanding PR for one of the exercises here (#417), and I'd be fine with pausing it from that point, adding the outstanding stubs for the remaining exercises separately, then putting them on the generator later, if that helps things move along. That should mean there are currently only up to 12 exercises that might not already have stubs. |
I like that suggestion. |
228292c
to
117653e
Compare
@m-dango I've rebased on the latest main and fixed the missing stub files and invalid file paths in this PR. configlet now only complains about an empty tags array:
|
In this PR, we created (empty) stub files for all exercises that didn't yet have them.
The lack of stub file generates an unnecessary pain point within Exercism, contributing a significant proportion of support requests, making things more complex for our students, and hindering our ability to automatically run test-suites and provide automated analysis of solutions.
The original discussion for this is at exercism/discussions#238.
Closes #319
We will automatically merge this PR in two week's time if it has not been merged by track maintainers at that point 🙂
Tracking
exercism/v3-launch#33