Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Add stub files to all exercises #401

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

ErikSchierboom
Copy link
Member

In this PR, we created (empty) stub files for all exercises that didn't yet have them.

The lack of stub file generates an unnecessary pain point within Exercism, contributing a significant proportion of support requests, making things more complex for our students, and hindering our ability to automatically run test-suites and provide automated analysis of solutions.

The original discussion for this is at exercism/discussions#238.

Closes #319

We will automatically merge this PR in two week's time if it has not been merged by track maintainers at that point 🙂

Tracking

exercism/v3-launch#33

@ErikSchierboom ErikSchierboom added the v3-migration 🤖 Preparing for Exercism v3 label May 4, 2021
@m-dango
Copy link
Member

m-dango commented May 20, 2021

This is likely going to conflict with #249 and #410. Once the pull request is merged most of the exercises should have stub files in place.

@ErikSchierboom
Copy link
Member Author

@m-dango Well, it's not only that the stub files have to be in place, but also that the paths in the exercises' .meta/config.json file should be correct. Is there any harm/danger in merging this PR first?

@m-dango
Copy link
Member

m-dango commented May 20, 2021

Many of the filenames will change as the generator creates them to match the file patterns in config.json. e.g. The changes in exercises/practice/secret-handshake/.meta/config.json for example will need to be undone.

Looking a bit closer, it seems that something has gone wrong with the secret-handshake changes. It looks like the solution file has been moved and the test is no longer able to find it, its expecting a SecretHandshake.pm file.

@ErikSchierboom
Copy link
Member Author

Many of the filenames will change as the generator creates them to match the file patterns in config.json. e.g. The changes in exercises/practice/secret-handshake/.meta/config.json for example will need to be undone.

Ah okay. I would then suggest to close this PR and wait for the other PRs to fix the issue of missing stubs. Agreed?

@ErikSchierboom
Copy link
Member Author

@m-dango Do you perhaps have any idea when #249 will be done? I'm asking as adding the stubs to perl5 is on my v3 launch to-do list :)

@m-dango
Copy link
Member

m-dango commented Jun 13, 2021

@ErikSchierboom I'm moving house roughly in the next couple weeks so I'm not too sure unfortunately. There is currently an outstanding PR for one of the exercises here (#417), and I'd be fine with pausing it from that point, adding the outstanding stubs for the remaining exercises separately, then putting them on the generator later, if that helps things move along.

That should mean there are currently only up to 12 exercises that might not already have stubs.

@ErikSchierboom
Copy link
Member Author

@ErikSchierboom I'm moving house roughly in the next couple weeks so I'm not too sure unfortunately. There is currently an outstanding PR for one of the exercises here (#417), and I'd be fine with pausing it from that point, adding the outstanding stubs for the remaining exercises separately, then putting them on the generator later, if that helps things move along.

I like that suggestion.

@ErikSchierboom
Copy link
Member Author

@m-dango I've rebased on the latest main and fixed the missing stub files and invalid file paths in this PR.

configlet now only complains about an empty tags array:

~/exercism/perl5$ ../configlet/configlet lint

The `tags` array is empty:
/home/erik/exercism/perl5/config.json

@ErikSchierboom ErikSchierboom requested review from m-dango and iHiD June 24, 2021 11:51
@ErikSchierboom ErikSchierboom merged commit 22ceada into exercism:main Jun 25, 2021
@ErikSchierboom ErikSchierboom added the x:size/tiny Tiny amount of work label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3-migration 🤖 Preparing for Exercism v3 x:size/tiny Tiny amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create stub files for all exercises
3 participants