-
-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating tests for poker exercise #2878
base: main
Are you sure you want to change the base?
Conversation
447c97f
to
d20e24a
Compare
The poker tests in the CI is failing. Does the example solution need updating?
|
…-tests-poker Pulling from remote
… into update-tests-poker Pulling from remote
I've updated the |
Unfortunaetly, the tests and Checkstyle tests are still failing. To run the tests locally, run
If you want to run just the poker test, use |
Thank you so much, @kahgoh, for this! I truly appreciate your guidance—I wasn’t aware we could run these tests locally, and this has been incredibly helpful. After testing the old reference answers on my local machine, I discovered that the initial reference implementation was failing five tests. Despite spending over two hours trying to understand the code, I found it overly complex and challenging to follow. A few days later, I attempted to use AI for assistance, but unfortunately, that approach also fell short. Eventually, I realized I could explore community solutions for inspiration. While I didn’t immediately find a fully working solution, analyzing the approaches helped me iterate and improve. During this process, I identified several excellent alternatives that were far more efficient and readable compared to the original implementation. However, these solutions all failed a newly added test case. This led me to uncover an oversight on my part—I had mistakenly marked the test as passed in the initial implementation. I sincerely apologize for this error. That said, since the original code was already failing four other tests, replacing it was necessary. After further investigation, I selected the best community solution available, which resolved most issues. I also located the GitHub profile of the original contributor and have appropriately credited them as a contributor to the project. [All tests have now been passed.] Please let me know if you have any thoughts or feedback on this update! |
Pull Request
This PR updates all 11 unsynced tests for the Poker exercise, including 2 reimplemented tests and newly added tests to align with the problem-specifications repository.
Reviewer Resources:
Track Policies