Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sqlserver support #451

Merged
merged 3 commits into from
May 28, 2024
Merged

Add sqlserver support #451

merged 3 commits into from
May 28, 2024

Conversation

excid3
Copy link
Owner

@excid3 excid3 commented May 28, 2024 •
edited
Loading

This adds support for sqlserver by setting the :json type on the params attribute.

Also refactored the ActiveRecord specifics into the Event model so they weren't also included in Ephemeral objects which are built on ActiveModel.

Fixes #450

excid3 added 2 commits May 28, 2024 10:24
@excid3
Add sqlserver support
a1d4724 
This injects SQLServer configuration into ApplicationNotifier as needed
when sqlserver adapter is detected.

Fixes #450
@excid3
Move params & serialize to Event and set json type
d25c368
@excid3 excid3 mentioned this pull request May 28, 2024
Closed
3 tasks
@excid3 excid3 merged commit 6dfb7d9 into main May 28, 2024
45 checks passed
@excid3 excid3 deleted the sqlserver-support branch May 28, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Noticed seems incompatible with MS SQL server (undefined method `has_key?' for an instance of String)
1 participant
@excid3