Fixups for running in switch mode #54
Conversation
…e host file won't have been created for leaf nodes on the first pass
| @@ -60,6 +60,7 @@ | |||
| command: awk '/^-----END RSA PUBLIC KEY-----$/' /etc/tinc/{{ tinc_netname }}/hosts/{{ inventory_hostname | replace('.','_') | replace('-','_') }} | |||
| changed_when: "public_key.stdout != '-----END RSA PUBLIC KEY-----'" | |||
| register: public_key | |||
| ignore_errors: yes | |||
There was a problem hiding this comment.
could you do failed_when: false instead?
Alternatively, what do you think of moving this task as a lineinfile with check_mode: yes? That might be better?
There was a problem hiding this comment.
I think changed_when is appropriate here; the issue is that awk fails, and then no further tasks get executed for that host. Apologies for being a little unclear.
I'll try the lineinfile approach, as it seems like it could be cleaner if it works :)
There was a problem hiding this comment.
Nevermind, I was misunderstanding failed_when. Will give that a go also.
|
FYI, for context, I didn't use the switch mode for a while. Maybe it would be good to have this covered by molecule :) |
|
@leigh-thg would you mind giving a look to a PR that rewrites a bunch of this, if I ever find the time? :) |
|
As you seem to care about this role, I spent some time refactoring it in #59 . It would be great if you could rebase your work on top of this. Thank you in advance. |
|
I have updated the role to make it simpler, and increase the test coverage. Can you test if the current role works better for you? If there is something missing, please feel free to update this PR or the one increasing coverage for switch: #69 |
|
Hi, Apologies for not getting back to this quicker. I can confirm with #69 that things work as expected. Many thanks! Leigh |
I needed to make the following changes to get a VPN up and running in switch mode
hostfile will not have been created yet, so theawkcommand fails. There may be a better way to accomplish this.