fix(journey): journeyId em todos executores (EVO-1917)#97
Open
daniloleonecarneiro wants to merge 1 commit into
Open
Conversation
…VO-1917)
Follow-up do EVO-1885: o dispatch do journey-execution.workflow.ts so
passava journeyId para send-webhook e scheduled-action. Os 15 executores
restantes que chamam interpolateNodeData nao recebiam journeyId, entao as
variaveis-default da jornada nao resolviam ({{var}} ficavam cruas) nesses
nos (inclui conditional e send-message).
Thread input.journeyId nos 15 cases de dispatch que interpolam e declara
journeyId?: string nas Input interfaces correspondentes. O fallback para
session.journeyId (EVO-1885) continua como rede de seguranca; este sweep
torna o caminho explicito robusto. Nos que nao interpolam (wait,
set-variable, split, trigger, exit, transfer, mute/resolve/snooze,
update-custom-attribute) nao sao tocados.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @daniloleonecarneiro, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
Follow-up do EVO-1885 (Done) — o e2e de jornadas (N3) mostrou o problema persistindo: no dispatch do
journey-execution.workflow.ts, apenassend-webhookescheduled-actionpassavamjourneyId. Os 15 executores restantes que chamaminterpolateNodeDatanão recebiamjourneyId, então as variáveis-default da jornada não resolviam ({{var}}ficavam cruas) — incluiconditional(valores de condição) esend-message(corpo da mensagem).Mudança (sweep — 15 executores)
Thread
journeyId: input.journeyIdnos 15 cases de dispatch que interpolam + declarajourneyId?: stringnas Input interfaces correspondentes, espelhando o padrão já correto desend-webhook/scheduled-action.Executores tocados: add-label, remove-label, update-contact, conditional, send-message, send-canned-response, send-email-team, send-transcript, assign-agent, assign-team, assign-bot, assign-to-pipeline, move-to-pipeline-stage, create-pipeline-task, change-priority.
Abordagem: threading pontual nos cases (o dispatch é um
switchsem chokepoint único onde injetar sem reestruturar). O fallback parasession.journeyId(EVO-1885, embase.node.ts) permanece como rede de segurança; este sweep torna o caminho explícito robusto. Nós que não interpolam (wait, set-variable, split, trigger, exit, transfer, mute/resolve/snooze, update-custom-attribute) não foram tocados.Contagem
journeyId?: stringbase.node.spec.ts)Testes
tsc -p tsconfig.json --noEmit: limpo (exit 0)EVOAI_CRM_API_TOKENsetado. Sem a env, 4 falhas pré-existentes (EVOAI_CRM_API_TOKEN environment variable is required) — independentes desta mudança.input.journeyIddespachado resolve variável-default mesmo quando a sessão em cache não carregajourneyId.Closes EVO-1917