Skip to content

refactor(journey): snooze-conversation-node orphan case (EVO-1920) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniloleonecarneiro wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −12
Open

refactor(journey): snooze-conversation-node orphan case (EVO-1920) #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions src/modules/temporal/workflows/journey-execution.workflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,19 +928,13 @@ export async function JourneyExecutionWorkflow(
});
break;

case 'snooze-conversation-node':
nodeResult =
await actionNodeActivities.executeSnoozeConversationNode({
nodeId: currentNode.id,
conversationId:
input.triggerEvent?.properties?.conversation_id || '',
sessionId: input.sessionId,
nodeData: currentNode.data,
});
break;

case 'defer-conversation-node':
// Defer aliases snooze — same CRM effect ('snoozed').
// `defer-conversation-node` is the single canonical node type the FE
// journey editor emits for "snooze/defer". The legacy
// `snooze-conversation-node` case was removed (EVO-1920): no FE node,
// trigger, or saved-journey fixture ever produced that type, so it was
// unreachable. The underlying CRM effect is still "snoozed", which is
// why the executor keeps the name `executeSnoozeConversationNode`.
nodeResult =
await actionNodeActivities.executeSnoozeConversationNode({
nodeId: currentNode.id,
Expand Down
Loading