Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for disabling Sanitization #132

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/render_tree.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ define(['./core', './markdown_helpers'], function(Markdown, MarkdownHelpers) {
var content = [];

if ( options.root ) {
content.push( render_tree( jsonml ) );
content.push( render_tree( jsonml, options ) );
}
else {
jsonml.shift(); // get rid of the tag
if ( jsonml.length && typeof jsonml[ 0 ] === "object" && !( jsonml[ 0 ] instanceof Array ) )
jsonml.shift(); // get rid of the attributes

while ( jsonml.length )
content.push( render_tree( jsonml.shift() ) );
content.push( render_tree( jsonml.shift(), options ) );
}

return content.join( "\n\n" );
Expand Down Expand Up @@ -83,7 +83,7 @@ define(['./core', './markdown_helpers'], function(Markdown, MarkdownHelpers) {
Markdown.toHTML = function toHTML( source , dialect , options ) {
var input = this.toHTMLTree( source , dialect , options );

return this.renderJsonML( input );
return this.renderJsonML( input, options );
};


Expand All @@ -95,10 +95,15 @@ define(['./core', './markdown_helpers'], function(Markdown, MarkdownHelpers) {
.replace( /'/g, "'" );
}

function render_tree( jsonml ) {
function K(input) { return input; }

function render_tree( jsonml, options ) {
// basic case

var sanitize = (options.sanitize !== false) ? escapeHTML : K;

if ( typeof jsonml === "string" )
return escapeHTML( jsonml );
return sanitize( jsonml );

var tag = jsonml.shift(),
attributes = {},
Expand All @@ -108,11 +113,16 @@ define(['./core', './markdown_helpers'], function(Markdown, MarkdownHelpers) {
attributes = jsonml.shift();

while ( jsonml.length )
content.push( render_tree( jsonml.shift() ) );
content.push( render_tree( jsonml.shift(), options ) );

var tag_attrs = "";
if (typeof attributes.src !== 'undefined') {
tag_attrs += ' src="' + sanitize( attributes.src ) + '"';
delete attributes.src;
}

for ( var a in attributes )
tag_attrs += " " + a + '="' + escapeHTML( attributes[ a ] ) + '"';
tag_attrs += " " + a + '="' + sanitize( attributes[ a ] ) + '"';

// be careful about adding whitespace here for inline elements
if ( tag === "img" || tag === "br" || tag === "hr" )
Expand Down
10 changes: 9 additions & 1 deletion test/features.t.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
var markdown = require("../src/markdown");
var markdown = require("../src/markdown"),
tap = require("tap");

function test_dialect( dialect, features ) {
var fs = require("fs"),
Expand Down Expand Up @@ -80,3 +81,10 @@ dialects.Maruku.push( "meta", "definition_lists", "tables" );
for ( var d in dialects ) {
test_dialect( d, dialects[ d ] );
}


tap.test("src attribute order", function(t) {
var tree = markdown.toHTML("![photo](/images/photo.jpg)");
t.equivalent( tree, '<p><img src="/images/photo.jpg" alt="photo"/></p>' );
t.end();
});
22 changes: 22 additions & 0 deletions test/html_renderer.t.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
var markdown = require("../src/markdown"),
tap = require("tap");

tap.test("src attribute order", function(t) {
var tree = markdown.toHTML("![photo](/images/photo.jpg)");
t.equivalent( tree, '<p><img src="/images/photo.jpg" alt="photo"/></p>' );
t.end();
});

tap.test("HTML Sanitizing", function(t) {
var input = "hello <world>";

t.equivalent( markdown.toHTML(input, 'Gruber'),
'<p>hello &lt;world&gt;</p>',
"escapes by default" );

t.equivalent( markdown.toHTML(input, 'Gruber', {sanitize: false}),
'<p>hello <world></p>',
"sanitization can be disabled" );

t.end();
});