Print exception stack trace in CsPackageManager.TryRun#229
Open
Honkbinger wants to merge 4 commits intoevilfactory:developfrom
Open
Print exception stack trace in CsPackageManager.TryRun#229Honkbinger wants to merge 4 commits intoevilfactory:developfrom
Honkbinger wants to merge 4 commits intoevilfactory:developfrom
Conversation
Author
|
At first i thought inner exception could never happen and is useless but now i found that exceptions in static constructors could trigger it |
Collaborator
|
Hi Honk, This is a good PR. I won't be able to merge it as we're doing a big code refactor. However, I will be manually implementing this into the Runner. Thanks for the contribution. I'm going to leave the PR open for now and will close it once implemented. |
Finally was able to compile luatrauma And stack trace seems to be 1 frame longer than in harmony patch also you need System.Diagnostics (kek)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is not very helpful


I suggest replacing it with at least this
Notes
You can just print e, but it's a bit ugly:

Idk how to capture line number
Also, in theory there's a simpler method:
But it's not available in .NET 6 :BaroDev: