chore: always require awaiting on promises before return (tediousjs…

…#1440) Always require `await`ing on promises before return.
everhardt · May 15, 2022 · 29557c4 · 29557c4
1 parent c44960c
commit 29557c4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -6,6 +6,7 @@ parser: "@typescript-eslint/parser"
 
 parserOptions:
   sourceType: "module"
+  project: "./tsconfig.json"
 
 plugins:
   - "@typescript-eslint"
@@ -93,7 +94,7 @@ rules:
       message: "Use `new` keyword when throwing an `Error`.",
     }
   ]
-  no-return-await: "error"
+  no-return-await: "off"
   no-self-assign: "error"
   no-self-compare: "error"
   no-tabs: "error"
@@ -193,6 +194,7 @@ overrides:
       "@typescript-eslint/prefer-namespace-keyword": "error"
       "@typescript-eslint/triple-slash-reference": "error"
       "@typescript-eslint/type-annotation-spacing": "error"
+      "@typescript-eslint/return-await": ["error", "always"]
       "no-var": "error"
       "prefer-const": "error"
       "prefer-rest-params": "error"

diff --git a/src/always-encrypted/keystore-provider-azure-key-vault.ts b/src/always-encrypted/keystore-provider-azure-key-vault.ts
@@ -201,7 +201,7 @@ export class ColumnEncryptionAzureKeyVaultProvider {
 
     this.createKeyClient(keyParts.vaultUrl);
 
-    return (this.keyClient as KeyClient).getKey(keyParts.name, keyParts.version ? { version: keyParts.version } : {});
+    return await (this.keyClient as KeyClient).getKey(keyParts.name, keyParts.version ? { version: keyParts.version } : {});
   }
 
   private createKeyClient(keyVaultUrl: string): void {