Update EventStore Client to latest #1059
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rasmus
reviewed
Oct 22, 2024
Comment on lines
+21
to
+24
| <ItemGroup> | ||
| <None Remove="C:\Work\Picup\git\EventFlow\Source\EventFlow.EventStores.EventStore\..\..\icon-128.png" /> | ||
| <None Remove="C:\Work\Picup\git\EventFlow\Source\EventFlow.EventStores.EventStore\..\..\README.md" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Suggested change
| <ItemGroup> | |
| <None Remove="C:\Work\Picup\git\EventFlow\Source\EventFlow.EventStores.EventStore\..\..\icon-128.png" /> | |
| <None Remove="C:\Work\Picup\git\EventFlow\Source\EventFlow.EventStores.EventStore\..\..\README.md" /> | |
| </ItemGroup> |
Comment on lines
+96
to
+101
| logger.LogDebug( | ||
| "Wrote entity {0} with version {1} ({2},{3})", | ||
| id, | ||
| expectedVersion, | ||
| writeResult.LogPosition.CommitPosition, | ||
| writeResult.LogPosition.PreparePosition); |
There was a problem hiding this comment.
{1} etc. should have proper names
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard2.0</TargetFrameworks> | ||
| <TargetFrameworks>net8.0</TargetFrameworks> |
There was a problem hiding this comment.
It would be awesome if all of them could be supported
Suggested change
| <TargetFrameworks>net8.0</TargetFrameworks> | |
| <TargetFrameworks>netstandard2.1;netcoreapp3.1;net6.0;net8.0</TargetFrameworks> |
|
Hmmm, seems EventStore is being re-branded https://www.kurrent.io/blog/kurrent-re-brand-faq Would it make sense to hold off completing this until the rebrand is done?
|
|
Here's the "correct" content (with old NuGet package references) needed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update EventStore Client to EventStore.Client.Grpc.Streams v23.3.5